> + this.status = checkNotNull(status, "status must be defined");
> + }
> +
> + /**
> + * @return boolean Return true when the server reaches status, false
> otherwise
> + */
> + @Override
> + public boolean apply(Server server) {
> + checkNotNull(server, "server must be defined");
> +
> + if (status.equals(server.getStatus())) {
> + return true;
> + }
> + else {
> + Server serverUpdated = serverApi.get(server.getId());
> + checkNotNull(serverUpdated, "Server %s not found.",
> server.getId());
Return `false` rather than throwing an NPE here? Otherwise, document the NPE or
make this an IllegalStateException?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/355/files#r12030498