Thanks, @everett-toews! Couple of general comments:

* Missing unit tests for `ServerPredicates`. Or do you feel they're not needed?
* Any thoughts about making `ServerPredicates` take `serverApi` as an instance 
parameter, rather than passing it to every invocation? That would avoid an 
"awkward" parameter, especially if you're calling this more often. I.e.:
```
ServerPredicates serverPredicates = new ServerPredicates(serverApi);
...
serverPredicates.awaitActive().apply(serverCreated); // or even 
awaitActive(serverCreated);?
serverPredicates.awaitActive().apply(serverCreated2);
```
instead of
```
ServerPredicates.awaitActive(serverApi).apply(serverCreated);
...
ServerPredicates.awaitActive(serverApi).apply(serverCreated2);
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/355#issuecomment-41504804

Reply via email to