The PR changes more things apart from the binder, and I think there should be, at least, the following tests, especially the expect ones:
>* CreateKeyPairPlacementAndSecurityGroupsAsNeededAndReturnRunOptionsTest >(simply add a method that tests the addSecurityGroups method) * AWSRunInstancesOptionsTest * SpotInstanceApiExpectTest There are no tests for the requestSpotInstancesInRegion (our fault), but having a method that tests it with a LaunchSpecification that uses your additions is important. Expect tests are end-to-end (mock-based) tests that verify the entire mechanism is working. If the test works, we know the REST API calls are being properly generated. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/333#issuecomment-44162311
