I think I didn't explain properly what I wanted to say. We need the three tests I mentioned in my last comment.
Regarding the `addSecurityGroups` one, there are not tests for other use cases of that method, but we need at least the ones that validate the changes in this PR. What I suggested was to add a method to the test class that directly calls the `addSecurityGroups` method with different inputs that make sense to the `associatePublicIpAddress` use case and check that the results are the expected ones. There is no need to cover all the paths of that method in this PR. Just the ones related to your additions --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/333#issuecomment-45194369
