> @@ -94,6 +99,12 @@ public boolean apply(FloatingIP arg0) {
> // try to prevent multiple parallel launches from choosing the same
> ip.
> Collections.shuffle(unassignedIps);
> ip = Iterables.getLast(unassignedIps);
> +
> + //if we are still unable to allocate IP, even after iterating
> through all
> + //available, then re-throw IRE as there is nothing left we can do
> + if(ip == null){
> + throw new InsufficientResourcesException("Failed to allocate a
> FloatingIP for node",e);
> + }
[minor] please add a space after the `//` and add complete the "...after
iterating through all available _" comment. Also, for the `if`, please use a
3-space indent and add spaces around the expression:
```
if (ip == null) {
throw new InsufficientResourcesException("Failed to allocate a FloatingIP
for node", e);
}
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/425/files#r14383451
