>           ip = floatingIpApi.create();
> +         if(ip == null){
> +              throw new InsufficientResourcesException();
> +         }

I wouldn't use exceptions to control the execution flow. I understand it might 
be trivial here, but it is in general a bad practice.

Could the code inside the catch be moved out to a method, call it from the 
catch and when the returned ip is `null`, and remove that `throws`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/425/files#r14391427

Reply via email to