> + *
> + * @param region the region to search in
> + * @param marker marks the beginning of the next list page
> + * @param listOptions listing options
> + * @return a page of the listPage
> + * @see org.jclouds.googlecomputeengine.options.ListOptions
> + * @see org.jclouds.googlecomputeengine.domain.ListPage
> + */
> + @Named("ForwardingRules:list")
> + @GET
> + @Consumes(MediaType.APPLICATION_JSON)
> + @Path("/regions/{region}/forwardingRules")
> + @OAuthScopes(COMPUTE_READONLY_SCOPE)
> + @ResponseParser(ParseForwardingRules.class)
> + @Fallback(EmptyIterableWithMarkerOnNotFoundOr404.class)
> + ListPage<ForwardingRule> listAtMarkerInRegion(@PathParam("region") String
> region, @QueryParam("pageToken") @Nullable String marker, ListOptions
> listOptions);
Do we really need three methods to get a concrete page? Could you refactor all
three into a single one that accepts the ListOptions object? The "pageToken"
parameter could be moved to that options object.
Also rename the method to the same name than the one that lists all records. In
general prefer method overloading for this kind of list methods.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/22/files#r15394268
