Thanks @andreaturli! Nice work (and nice documentation!). A few general comments:
* [ ] Remove the `author` tags from the javadoc comments. * [ ] Some license headers are not properly formatted. * [ ] Review the domain model classes: add the serialization annotations to the class member variables to match the ones defined in the `@ConstructorProeprties` annotation. * [ ] In the domain object constructors, add the `@Nullable` annotation to all nullable fields. * [ ] The APIs seem to always consume json. Move the `@Consumes` annotations at class level and remove them from the methods. * [ ] There are many methods to list paginated collections. For each one, there should be only two: * One without parameters that lists all records and returns a `PagedIterable`. * One with a single `Options` parameter that lists the records with the given criteria (including the page number, if provided), and returns an `IterableWithMarker` (a single page, but getting the `PagedIterable` from it is trivial). * [ ] There are some APIs that provide many `create` methods. Consider creating the corresponding `CreateOptions` objects and leave only two methods: one without parameters, and one with the options object. * [ ] Add the expect tests for the `HealthCheckApi`. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/22#issuecomment-50132223
