> @@ -88,7 +87,8 @@ > @Singleton > Gson provideGson(TypeAdapter<JsonBall> jsonAdapter, DateAdapter adapter, > ByteListAdapter byteListAdapter, > ByteArrayAdapter byteArrayAdapter, PropertiesAdapter > propertiesAdapter, JsonAdapterBindings bindings, > - OptionalTypeAdapterFactory optional, SetTypeAdapterFactory set, > ImmutableSetTypeAdapterFactory immutableSet, > + OptionalTypeAdapterFactory optional, SetTypeAdapterFactory set, > ImmutableMapDeserializer immutableMap, > + ImmutableSetTypeAdapterFactory immutableSet,
A minor on the naming and location: * move the constructor arg to a position _after_ all the TypeAdapterFactories? At first glance I thought this new argument was a TAF like all the others * I know it implements JsonDeserializer, but call it ImmutableMapTypeAdapter since we're going to register it as a type adapter? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/455/files#r15439119
