> @@ -88,7 +87,8 @@ > @Singleton > Gson provideGson(TypeAdapter<JsonBall> jsonAdapter, DateAdapter adapter, > ByteListAdapter byteListAdapter, > ByteArrayAdapter byteArrayAdapter, PropertiesAdapter > propertiesAdapter, JsonAdapterBindings bindings, > - OptionalTypeAdapterFactory optional, SetTypeAdapterFactory set, > ImmutableSetTypeAdapterFactory immutableSet, > + OptionalTypeAdapterFactory optional, SetTypeAdapterFactory set, > ImmutableMapDeserializer immutableMap, > + ImmutableSetTypeAdapterFactory immutableSet,
> I am not completely convinced about the second point, but it seems it will be > somewhat confusing either way anyways. My take would be that the class itself serves as a type adapter which does the adapting by deserializing JSON. So the latter is an "implementation detail" whilst the former describes the purpose of the class. But I'm also OK with `ImmutableMapDeserializer` if you really prefer that. Irrespective of that, how do you feel about moving the argument until after all the TAFs? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/455/files#r15481964
