> @@ -221,7 +221,11 @@ public SecurityGroup addIpPermission(IpPermission
> ipPermission, SecurityGroup gr
> Firewall.Rule.Builder ruleBuilder = Firewall.Rule.builder();
> ruleBuilder.IpProtocol(ipPermission.getIpProtocol());
> if (ipPermission.getToPort() > 0) {
This isn't really in the scope of this change, I know, but why this check here?
If we're verifying the "to" port, shouldn't we also check the "from" port?
Especially since toPort > 0 wouldn't seem to immediately imply fromPort > 0?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/39/files#r16080107
