> @@ -221,7 +221,11 @@ public SecurityGroup addIpPermission(IpPermission 
> ipPermission, SecurityGroup gr
>        Firewall.Rule.Builder ruleBuilder = Firewall.Rule.builder();
>        ruleBuilder.IpProtocol(ipPermission.getIpProtocol());
>        if (ipPermission.getToPort() > 0) {
> -         ruleBuilder.addPortRange(ipPermission.getFromPort(), 
> ipPermission.getToPort());
> +         if (ipPermission.getToPort() == ipPermission.getFromPort()) {

[minor] I would be tempted to switch "from" and "to" ports in the comparison, 
because I tend to talk about ranges as "from X to Y", but that's just a 
personal preference - up to you.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/39/files#r16080162

Reply via email to