>
> - assertEquals(Iterables.getOnlyElement(newGroup.getIpPermissions()),
> perm,
> - "Expecting IpPermission " + perm + " but group was " +
> newGroup);
> + singlePortBuilder.ipProtocol(IpProtocol.UDP);
> + singlePortBuilder.fromPort(41);
> + singlePortBuilder.toPort(41);
> + singlePortBuilder.cidrBlock("1.1.1.1");
> +
> + IpPermission singlePortIpPermission = singlePortBuilder.build();
> +
> + Set<IpPermission> expectedPermissions =
> ImmutableSet.of(portRangeIpPermission, singlePortIpPermission);
> +
> + SecurityGroup newGroup =
> securityGroupExtension.get().addIpPermission(singlePortIpPermission, group);
> +
> + assertTrue(difference(expectedPermissions,
> newGroup.getIpPermissions()).isEmpty(), "Expecting IpPermissions "
Almost trivial comment, but do we need `difference` here? Does
[`assertEquals`](http://testng.org/javadoc/org/testng/Assert.html#assertEquals(java.util.Set,
java.util.Set)) not work? E.g.
```
assertEquals(expectedPermissions, newGroup.getIpPermissions());
```
? That should also create the appropriate failure message automatically.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/477/files#r16109938
