> Ah, interesting! Wasn't aware of that either - sorry to induce that coupling. > If you prefer, we can also > split it out into a separate test again, but it seems OK as it is currently? > What do you prefer?
Yeah I think the test is fine as it is. It covers the single port case and it adds some variation in the other parameters too. > I should ask: are the tests passing (with your patch to support single port > ranges applied) at the > moment, or still failing? So I have run the live tests in google-compute-engine and the test I changed (BaseSecurityGroupExtensionLiveTest) passes. However, as explained above another test (GoogleComputeEngineServiceLiveTest) fails due to the key being text and not a file path. Which I assume was the case already. However, I haven't run the live tests for all the other providers - I don't have accounts with most of those. I'm not sure what your set up for that is? Does the CloudBees run live over all the providers or does it just run the unit tests? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/477#issuecomment-52082739
