> +      String deviceName = null;
> +
> +      /**
> +       * @param volumeId ID of the volume within the block store that you 
> wish to attach
> +       */
> +      public BlockDeviceMapping volumeId(String volumeId){
> +         this.volumeId = volumeId;
> +         return this;
> +      }
> +
> +      /**
> +       * @param deleteOnTermination True if this volume should be deleted 
> when the instance is terminated
> +       */
> +      public BlockDeviceMapping deleteOnTermination(boolean 
> deleteOnTermination){
> +         // Nova expects this to be a string
> +         this.deleteOnTermination = deleteOnTermination ? "1" : "0";

[minor] Worth extracting `"0"` and `"1"` into constants here? What do you 
think, @jdaggett?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/326/files#r16819190

Reply via email to