> @@ -98,6 +98,51 @@ public String toString() {
>  
>     }
>  
> +   /**
> +    * A representation of block device that should be attached to the 
> instance to be launched
> +    *
> +    */
> +   public static class BlockDeviceMapping {

I would extract this class into its own domain class 
`org.jclouds.openstack.nova.v2_0.domain.BlockDeviceMapping` similar to other 
domain classes. Refer to the Neutron 
[Network](https://github.com/jclouds/jclouds-labs-openstack/blob/master/openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/Network.java)
 as an example of how domain classes are being modeled going forward.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/326/files#r16849785

Reply via email to