> +            return listNodes(instance);
> +         } catch (Throwable e) {
> +            logger.error("Can't find vm", e);
> +            throw closer.rethrow(e);
> +         } finally {
> +            closer.close();
> +         }
> +      } catch (Throwable t) {
> +         return ImmutableSet.of();
> +      }
> +   }
> +
> +   @Override
> +   public Iterable<VirtualMachine> listNodesByIds(Iterable<String> ids) {
> +      Iterable<VirtualMachine> nodes = listNodes();
> +      Iterable<VirtualMachine> selectedNodes = Iterables.filter(nodes, 
> VSpherePredicate.isNodeIdInList(ids));

Would it be more efficient to get the N nodes in the list instead of listing 
them all and filtering locally?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/61/files#r18061645

Reply via email to