I've been reviewing the code for a while now, mainly focused on the 
ComputeService implementation, and I think there is enough TBD before we 
continue with the rest:

* If I am not wrong, all these API classes that are tied to vijava don't have 
an implementation. Why are they needed? Can they be removed?
* Several methods in the ComputeService are huge. That makes them have many 
uncontrolled errors and many execution paths. They must be broke down into 
smaller parts and all errors must be properly handled.
* Use the try-with-resources to handle all closer stuff.
* Move all hardcoded scripts to resource files in the classpath.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-56889074

Reply via email to