Note - this is just a preliminary PR, not ready for merge yet. I still have to add a couple more expect tests, update a couple more, add live tests and update one or two other live tests, but I wanted to throw this up so others could see it.
Note also that yeah, I went a little nutty and reformatted most of the json test files I touched to actually be readable, so the PR may look a bit uglier than it actually is. Hey, going forward, readability's nice, right? =) You can merge this Pull Request by running: git pull https://github.com/abayer/jclouds-1 jclouds-756 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/578 -- Commit Summary -- * First chunk of work - adding tags everywhere. Tests to come. * Updated response/expect tests for existing stuff * Add ListTags tests * Create/delete tags options tests * First gasp of TagApi tests * List*Options tests * listTags expect tests * TODO: -- File Changes -- M apis/cloudstack/src/main/java/org/jclouds/cloudstack/CloudStackApi.java (7) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/FirewallRule.java (41) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/IPForwardingRule.java (41) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/ISO.java (43) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/IngressRule.java (46) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/Network.java (45) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/PortForwardingRule.java (43) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/Project.java (52) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/PublicIPAddress.java (40) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/SecurityGroup.java (39) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/Snapshot.java (41) A apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/Tag.java (353) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/Template.java (47) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/VirtualMachine.java (39) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/Volume.java (40) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/Zone.java (40) A apis/cloudstack/src/main/java/org/jclouds/cloudstack/features/TagApi.java (89) A apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/CreateTagsOptions.java (124) A apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/DeleteTagsOptions.java (111) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListEgressFirewallRulesOptions.java (25) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListFirewallRulesOptions.java (25) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListIPForwardingRulesOptions.java (26) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListISOsOptions.java (23) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListNetworksOptions.java (52) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListPortForwardingRulesOptions.java (27) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListProjectsOptions.java (25) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListPublicIPAddressesOptions.java (25) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListSecurityGroupsOptions.java (29) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListSnapshotsOptions.java (24) A apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListTagsOptions.java (247) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListTemplatesOptions.java (25) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListVirtualMachinesOptions.java (25) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListVolumesOptions.java (24) M apis/cloudstack/src/main/java/org/jclouds/cloudstack/options/ListZonesOptions.java (23) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/FirewallApiExpectTest.java (51) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ProjectApiExpectTest.java (43) A apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/TagApiExpectTest.java (89) A apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/TagApiTest.java (123) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/features/ZoneApiExpectTest.java (19) A apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/CreateTagsOptionsTest.java (102) A apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/DeleteTagsOptionsTest.java (91) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListIPForwardingRulesOptionsTest.java (19) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListISOsOptionsTest.java (19) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListNetworksOptionsTest.java (19) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListPortForwardingRulesOptionsTest.java (18) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListPublicIPAddressesOptionsTest.java (18) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListSecurityGroupsOptionsTest.java (18) A apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListTagsOptionsTest.java (152) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListTemplatesOptionsTest.java (18) R apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListVirtualMachinesOptionsTest.java (20) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/options/ListZonesOptionsTest.java (18) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListFirewallRulesResponseTest.java (7) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListIPForwardingRulesResponseTest.java (9) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListNetworksResponseTest.java (11) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListPortForwardingRulesResponseTest.java (15) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListPublicIPAddressesResponseTest.java (13) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListSecurityGroupsResponseTest.java (31) A apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListTagsResponseTest.java (66) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListTemplatesResponseTest.java (3) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListVirtualMachinesResponse3xTest.java (17) M apis/cloudstack/src/test/java/org/jclouds/cloudstack/parse/ListZonesResponseTest.java (25) M apis/cloudstack/src/test/resources/getportforwardingrulesresponse.json (19) M apis/cloudstack/src/test/resources/listegressfirewallrulesresponse.json (5) M apis/cloudstack/src/test/resources/listfirewallrulesresponse.json (5) M apis/cloudstack/src/test/resources/listipforwardingrulesresponse.json (3) M apis/cloudstack/src/test/resources/listnetworksresponse.json (96) M apis/cloudstack/src/test/resources/listportforwardingrulesresponse.json (30) M apis/cloudstack/src/test/resources/listprojectsresponse.json (36) M apis/cloudstack/src/test/resources/listpublicipaddressesresponse.json (32) M apis/cloudstack/src/test/resources/listsecuritygroupsresponse.json (118) A apis/cloudstack/src/test/resources/listtagsresponse.json (16) M apis/cloudstack/src/test/resources/listtemplatesresponse.json (130) M apis/cloudstack/src/test/resources/listvirtualmachinesresponse3x.json (57) D apis/cloudstack/src/test/resources/listvolumesreponse-imageextension.json (2) M apis/cloudstack/src/test/resources/listzonesresponse.json (30) -- Patch Links -- https://github.com/jclouds/jclouds/pull/578.patch https://github.com/jclouds/jclouds/pull/578.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/578
