> +      final Map<String, String> meta = 
> template.getOptions().getUserMetadata();
> +      final StorageApi storageApi = pbApi.getStorageApi();
> +
> +      vdcWaitingPredicate.apply(locationId);
> +      // Create actual server
> +      CreateServerRequest serverToCreate = templateToServer.apply(template);
> +
> +      final ServerApi serversApi = pbApi.getServersApi();
> +      logger.trace(">> creating new server from template [%s]", 
> serverToCreate);
> +      String createdServerId = 
> serversApi.createServer(serverToCreate).getReturn().getServerId();
> +      checkNotNull(createdServerId);
> +      logger.trace("<< server created with id=%s", createdServerId);
> +      vdcWaitingPredicate.apply(locationId);
> +
> +      // Because of JCLOUDS-482 (arbitrary for virtual "storage" as well), 
> below retrieves storages to provision via metadata
> +      final Set<String> storageIds = Sets.newLinkedHashSet();

In all code prefer list to set unless set semantics are meaningful. Lists are 
cheaper and less confusing. ( I know we over-use set in existing code )

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/72/files#r19648491

Reply via email to