@devcsrj wow. you have written some nice code! good job.

So I made some comments, and I have a general one, considering our direction as 
late is to remove as much domain (value) object burden as possible. I noticed 
that you are using string binders on the way out and jaxb on the way in.

JAXB leads to complicated annotations and leads to complex types which may not 
actually be nice to use. Also, you can't make immutable objects, which means 
tools like AutoValue cannot be used. Lastly, android won't work with jaxb ( not 
that this is an immediate concern).

I'd like to ask you to switch to using sax parsing. At first, it may seem like 
a lot of work, but considering you can use auto-value types and the api will 
look very clean at the end of the day, I think it could be worthwhile. Can you 
try? Look at azurecompute as an example.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/72#issuecomment-61206378

Reply via email to