I've addressed the comments. Here is the summary: * Refactored the code to reuse the OkHttp client. * I built all downstream projects and the following changes will be required to Glacier and GCE: https://github.com/nacx/jclouds-labs-aws/commit/e5dc6b5555e24f18dd1bd12e3e136cde4cb2d724 and https://github.com/nacx/jclouds-labs-google/commit/069eb64292e36805316b736b2f0912de63f0daf0. Once this is merged I'll raise the corresponding PRs to checking those commits. * I fixed the OpenStack Keystone retry handler to not release the Payload. @adriancole I think in general we should avoid doing that in the RetryHandlers: after them, always the response parser, or the error handler will be executed, and they should be the ones to have the responsibility of releasing the payload; not the RetryHandler, which only makes the "retry decision". Do you agree to set this as a practice? * I've configured the Animal Sniffer plugin to detect runtime incompatibilities with Java 6. This way we can get rid of the Java 6 builder, but still be confident that our code will run in a JRE 6 without issues. @demobox Can we disable again the Java 6 build once this commit is in? (/cc @andrewgaul @everett-toews)
Once this is OK I'll squash the commits and leave only two: one for the OkHttp changes, and one for the Animal Sniffer plugin. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/617#issuecomment-64781974
