This is not ready to be merged.
Some of the live tests are still failing. I wanted to ask if I am missing some
way to pass credentials into these test.
Currently I am overriding all the tests that require credentials to SSH into an
instance and adding the following lines:
`template.getOptions().overrideLoginCredentials(loginCredentials);`
`template.getOptions().authorizePublicKey(this.keyPair.get("public"));`
@nacx any better ways to pass credentials into these live test?
You can merge this Pull Request by running:
git pull https://github.com/GoogleCloudPlatform/jclouds-labs-google
overrideTestFix
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/116
-- Commit Summary --
* dabbleing with fixes, still broken
-- File Changes --
M
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java
(53)
M
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/options/GoogleComputeEngineTemplateOptions.java
(3)
M
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java
(2)
M
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceLiveTest.java
(403)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/116.patch
https://github.com/jclouds/jclouds-labs-google/pull/116.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/116
