[
https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321127#comment-14321127
]
Daniel Broudy commented on JCLOUDS-805:
---------------------------------------
Below(1) is a temporary fix that highlights the problem and passes tests.
L79 linked below(2): algorithm.getNextPart() is reused between tests so
continues counting up causing ((partCount + 1) == partNum) to never be true
after the first multipart upload.
I'm not sure if we are iterating one time too many by going to partCount+1,
I'll have to look closer at MultipartUploadSlicingAlgorithm.
Is it common for SequentialMultipartUploadStrategy to be reused or is that
unique to test?
(1)
[https://github.com/danbroudy/jclouds-labs-google/commit/b85f1d507433f8d00a2de6f46dd600b171a7fdc1]
(2)
[https://github.com/danbroudy/jclouds-labs-google/blob/b85f1d507433f8d00a2de6f46dd600b171a7fdc1/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java#L79-L81]
> Google Cloud Storage integration test failures
> ----------------------------------------------
>
> Key: JCLOUDS-805
> URL: https://issues.apache.org/jira/browse/JCLOUDS-805
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-blobstore, jclouds-labs-google
> Affects Versions: 1.9.0
> Reporter: Andrew Gaul
> Assignee: Bhathiya Supun
> Labels: google-cloud-storage
> Fix For: 1.9.0
>
> Attachments: testresults.txt
>
>
> {noformat}
> Failed tests:
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:277
> null
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372
> » ResourceNotFound
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListContainerGetBlobSize:409
> expected [42] but found [null]
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListMarkerAfterLastKey:88
> » HttpResponse
> ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object
> to not be null
> ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to
> not be null
> BucketApiLiveTest.testPatchBucket:192 » Authorization {
> "error": {
> "errors"...
> BucketApiLiveTest.testUpdateBucket:133 » Authorization {
> "error": {
> "errors...
> BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization {
> "error": ...
> ObjectApiLiveTest.testSimpleJpegUpload:157->checkHashCodes:399 expected
> [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62]
> ObjectApiLiveTest.testUpdateObject:293 » Authorization {
> "error": {
> "errors...
> ObjectApiLiveTest.deleteBucket:425 » IllegalState {
> "error": {
> "errors": [
> ...
> Tests run: 100, Failures: 14, Errors: 0, Skipped: 17
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
