> + @POST
> + @Named("snapshot:update")
> + @MapBinder(UpdateSnapshotRequestBinder.class)
> + @XMLResponseParser(RequestIdOnlyResponseHandler.class)
> + String updateSnapshot(@PayloadParam("snapshot")
> Snapshot.Request.UpdatePayload payload);
> +
> + @POST
> + @Named("snapshot:delete")
> +
> @Payload("<ws:deleteSnapshot><snapshotId>{id}</snapshotId></ws:deleteSnapshot>")
> + @Fallback(Fallbacks.FalseOnNotFoundOr404.class)
> + boolean deleteSnapshot(@PayloadParam("id") String id);
> +
> + @POST
> + @Named("snapshot:rollback")
> + @MapBinder(RollbackSnapshotRequestBinder.class)
> + boolean rollbackSnapshot(@PayloadParam("snapshot")
> Snapshot.Request.RollbackPayload payload);
So, if I understand this properly, this method will never return false. If it
suceeds returns "true", and fails with an exception otherwise. It sounds better
to me to return the requestId or just `void`. WDYT?
Regarding the delete method: does the API actually return a 404? If the API
never returns a 404, then remove the fallback and apply the same criteria
applied to the rollback method.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/136/files#r25151779
