> +   @POST
> +   @Named("snapshot:update")
> +   @MapBinder(UpdateSnapshotRequestBinder.class)
> +   @XMLResponseParser(RequestIdOnlyResponseHandler.class)
> +   String updateSnapshot(@PayloadParam("snapshot") 
> Snapshot.Request.UpdatePayload payload);
> +
> +   @POST
> +   @Named("snapshot:delete")
> +   
> @Payload("<ws:deleteSnapshot><snapshotId>{id}</snapshotId></ws:deleteSnapshot>")
> +   @Fallback(Fallbacks.FalseOnNotFoundOr404.class)
> +   boolean deleteSnapshot(@PayloadParam("id") String id);
> +
> +   @POST
> +   @Named("snapshot:rollback")
> +   @MapBinder(RollbackSnapshotRequestBinder.class)
> +   boolean rollbackSnapshot(@PayloadParam("snapshot") 
> Snapshot.Request.RollbackPayload payload);

Oh, right. For delete and list methods, the fallback should be OK. jclouds 
already [handles the fault 
xml](https://github.com/jclouds/jclouds-labs/blob/master/profitbricks/src/main/java/org/jclouds/profitbricks/http/ResponseStatusFromPayloadHttpCommandExecutorService.java#L95-L100)
 and returns a response with the appropriate response code, so forget about 
delete and the other existing methods.
I just didn't find the boolean return value that "meaningful" in the rollback 
method. Returning the request id looks more appropriate.


---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/136/files#r25152959

Reply via email to