> +                     credentialsBuilder.up();
> +                     add(configBuilder, "JoinDomain", 
> domainJoin.joinDomain());
> +                     
> configBuilder.e("JoinDomain").t(winParams.domainJoin().joinDomain()).up()
> +                           .up(); // Domain Join
> +                  }
> +                  configBuilder.e("StoredCertificateSettings").up()
> +                        .up(); // Windows ConfigurationSet
> +               } else if (roleParam.OSVirtualHardDiskParam().OS() == 
> OSImage.Type.LINUX) {
> +                  LinuxConfigurationSetParams linuxParams = 
> roleParam.linuxConfigurationSet();
> +                  XMLBuilder configBuilder = 
> configSetsBuilder.e("ConfigurationSet")
> +                        .a("i:type", "LinuxProvisioningConfigurationSet"); 
> // Linux
> +                  
> configBuilder.e("ConfigurationSetType").t("LinuxProvisioningConfiguration").up();
> +                  add(configBuilder, "HostName", linuxParams.hostName());
> +                  add(configBuilder, "UserName", linuxParams.userName());
> +                  add(configBuilder, "UserPassword", 
> linuxParams.userPassword());
> +                  
> configBuilder.e("DisableSshPasswordAuthentication").t("false").up()

Wouldn't it better to use constants for defining these strings?
Thanks

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157/files#r27139626

Reply via email to