> + RoleSize.Type roleSize = roleParam.roleSize();
> + if (roleSize != null) {
> + roleBuilder.e("RoleSize").t(roleSize.getText()).up();
> + }
> + // add(builder, "AvailabilitySetName",
> params.availabilitySetName);
> + Boolean agent = roleParam.provisionGuestAgent();
> + if (agent != null) {
> +
> roleBuilder.e("ProvisionGuestAgent").t(agent.toString()).up();
> + }
> +
> + }
> + roleBuilder.up(); // role
> + }
> + roleListBuilder.up(); // RoleList
> + add(builder, "VirtualNetworkName", params.virtualNetworkName());
> + builder.up();
> // TODO: Undeprecate this method as forcing users to wrap a String
> in guava's ByteSource is not great.
> return (R) request.toBuilder().payload(builder.asString()).build();
> } catch (Exception e) {
It might be better to add a meaningful message inside the catch block when
propagating an exception. Otherwise it would be difficult for users to
understand which functionality did not work when an exception is raised.
Thanks
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157/files#r27139966
