> + .template(template)
> + .templateUrl(templateUrl)
> + .parameters(parameters)
> + .disableRollback(disableRollback)
> + .files(files)
> + .environment(environment).build();
> + }
> +
> + public static final class Builder {
> +
> + private String name;
> + private String template;
> + private String templateUrl;
> + private Map<String, Object> parameters = new
> ImmutableMap.Builder<String, Object>().build();
> + private boolean disableRollback = true;
> + private Map<String, String> files = new ImmutableMap.Builder<String,
> String>().build();
When I suggested using a builder, I was suggesting another approach: Initialize
the builder variable as just the Builder, and call its `putAll` method when
someone calls the builder method with a map. Finally, in the `build()` method,
call the map builder build to generate the final map.
IMO this approach is more understandable than the current one (which is the
same than the old one that just reassigned an existing map).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/188/files#r28953779
