> +            .template(template)
> +            .templateUrl(templateUrl)
> +            .parameters(parameters)
> +            .disableRollback(disableRollback)
> +            .files(files)
> +            .environment(environment).build();
> +   }
> +
> +   public static final class Builder {
> +
> +      private String name;
> +      private String template;
> +      private String templateUrl;
> +      private Map<String, Object> parameters = new 
> ImmutableMap.Builder<String, Object>().build();
> +      private boolean disableRollback = true;
> +      private Map<String, String> files =  new ImmutableMap.Builder<String, 
> String>().build();

I suggested that because IIRC the fields in the builder were actually 
initialised to an empty map. What you say also makes sense. In that case, let's 
leave the fields uninitialised and don't use builders, as it does not make 
sense.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/188/files#r28997578

Reply via email to