[ 
https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493053#comment-15493053
 ] 

Andrew Phillips commented on JCLOUDS-1166:
------------------------------------------

_> what do you think about the custom bundle approach?_

[~nacx]: If we can make a new bundle using the Gson lib directly as the source, 
and only including and exporting the relevant internal files, I think that 
could work, yes - sounds like a good idea to me!

I'd be more hesitant about copying the files out and bundling them up 
ourselves, as then I think there would be a risk that we end up with different 
files in non-OSGi environments (where we would get the files straight from the 
Gson JAR) vs. OSGi environments (where we would get our copies files from the 
custom bundle).

Was the "shade straight from the Gson JAR" the approach you had in mind?

> Remove uses of the 'com.google.gson.internal' package
> -----------------------------------------------------
>
>                 Key: JCLOUDS-1166
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1166
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-chef, jclouds-core
>    Affects Versions: 1.9.2
>            Reporter: Ignasi Barrera
>              Labels: gson
>
> Starting from Gson 2.6, the {{com.google.gson.internal}} packages are no 
> longer exported in the OSGi bundles. This makes it impossible to use jclouds 
> in an OSGi environment if upgrading to such versions of Gson.
> There is no change to add the exports back for that package (see [this 
> discussion|https://github.com/google/gson/pull/916]), so we should stop using 
> those classes.
> See also: http://markmail.org/message/olgebygfgdy3hwtm



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to