This is a follow-up to
https://github.com/jclouds/jclouds/pull/1091#issuecomment-299202429.
> +1 to merging this but I have been trying this out and I think we will need
> to extend it for practical purposes; if you want to create a VPC and subnet
> and then depl>oy a machine on to it, you also need to jump through a few
> other hoops apart from creating the subnet:
>
> modify the subnet attributes to permit auto-assign public IP
> ("ModifySubnetAttribute")
> create an Internet Gateway on the VPC ("CreateInternetGateway")
> get and then modify the routing table of the subnet to add a public
> (0.0.0.0/0) route through the newly added gateway ("CreateRoute" and friends)
> But as mentioned let's merge this as-is, and do any such new stuff as a new
> PR!
This PR adds the capability to modify the subnet to auto-assign the public IP
via `ModifySubnetAttribute`.
It turned out that the `ModifySubnetAttribute` is a method that has been added
to the AWS API subsequent to the version `2012-06-01` of the other subnet
methods; to allow the selective specification of a different version I am
proposing in this PR the introduction of a new annotation `ApiVersionOverride`,
q.v. and see its use in
https://github.com/jclouds/jclouds/compare/master...geomacy:modify-subnet-attribute?expand=1#diff-aa0b3b1bb310c30b9f8fdbab82794412R145
The annotation is processed by `FormSignerV4`; should I do this in
`FormSignerV2` as well?
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1102
-- Commit Summary --
* Add ModifySubnetAttribute
-- File Changes --
M apis/sts/src/main/java/org/jclouds/aws/filters/FormSignerV4.java (27)
A core/src/main/java/org/jclouds/rest/annotations/ApiVersionOverride.java
(44)
M
providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/AWSSubnetApi.java
(23)
A
providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/options/ModifySubnetAttributeOptions.java
(86)
M
providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSSubnetApiLiveTest.java
(24)
M
providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/AWSSubnetApiMockTest.java
(20)
M
providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/internal/BaseAWSEC2ApiMockTest.java
(9)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1102.patch
https://github.com/jclouds/jclouds/pull/1102.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1102
