kishorebattula commented on this pull request.
> + setResultOrException(command, finalFuture, response);
+ } else {
+ cleanup(nativeRequest);
+ setResultOrException(command, finalFuture, response);
+ }
+ }
+
+ @Override
+ public void onFailure(Throwable t) {
+ handleInvokeAsyncFailure(t, command, finalFuture);
+ }
+ });
+ } catch (Exception e) {
+ handleInvokeAsyncFailure(e, command, finalFuture);
+
+ }
@nacx In the retry handler, we are calling different methods i.e invoke in one
case and invokeAsync in another case. I have to think whether we can avoid it
or not. We can wrap sync in immediateFuture and I don't think it will have any
performance impact as such. Are you suggesting to change the return type of
invoke method to Future?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1114#discussion_r123426346
