nacx commented on this pull request.
> + setResultOrException(command, finalFuture, response);
+ } else {
+ cleanup(nativeRequest);
+ setResultOrException(command, finalFuture, response);
+ }
+ }
+
+ @Override
+ public void onFailure(Throwable t) {
+ handleInvokeAsyncFailure(t, command, finalFuture);
+ }
+ });
+ } catch (Exception e) {
+ handleInvokeAsyncFailure(e, command, finalFuture);
+
+ }
>Are you suggesting to change the return type of invoke method to Future?
Yes. It could not look OK, but it is an internal method, and I wanted to
explore if we could benefit from having just one way of invoking the underlying
transport method. I just wanted to see if the overhead introduced by the
immediate future are worth having a cleaner implementation with just one method.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1114#discussion_r123459474
