code4clouds commented on this pull request.
> +package org.jclouds.azurecompute.arm.domain;
+
+import com.google.auto.value.AutoValue;
+import com.google.common.collect.ImmutableList;
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import java.util.List;
+
+@AutoValue
+public abstract class ExtensionProfileSettings {
+
+ /**
+ * The fileUris reference of the extension profile settings
+ */
+ @Nullable
@nacx There are two reasons why these @nulleable are valid and should stay:
1-If the nullable is removed the tests fail as there aren't any value in this
case (as real response) null is appropriate. It is not really the anti-pattern
case for this, because null is not used to handle exceptions.
2- The @nulleable came from previous developed/approved code already used by
our jclouds customers. We will be having two different implementations under
the same package.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/412#discussion_r147452678
