nacx commented on this pull request.
> + String subnetName = String.format("s-%s-%s",
> this.getClass().getSimpleName().toLowerCase(),
> System.getProperty("user.name"));
+ this.subnet = createDefaultSubnet(resourceGroupName, subnetName,
virtualNetworkName, "10.2.0.0/23");
+ assertNotNull(subnet);
+ assertNotNull(subnet.id());
+ this.subnetId = subnet.id();
+
+
+ vmssName = String.format("%3.24s", System.getProperty("user.name") +
RAND + this.getClass().getSimpleName()).toLowerCase().substring(0, 15);
+ }
+
+ @Test
+ public void testCreate() {
+ VirtualMachineScaleSet vmss = api().createOrUpdate(vmssName,
LOCATIONDESCRIPTION, getSKU(),
+ Collections.<String, String>emptyMap(), getProperties());
+ assertTrue(!vmss.name().isEmpty());
+ }
Yes, but relying on that you're not testing the list, get, and delete methods.
It is OK to rely on that teardown, but the methods in the API must have
explicit tests.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/412#discussion_r148758708
