nacx commented on this pull request.
Thanks @trevorflanagan! Just one small comment.
> @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final
> CreateNodeWithGroupEncod
final DimensionDataCloudControlTemplateOptions templateOptions =
template.getOptions()
.as(DimensionDataCloudControlTemplateOptions.class);
- String networkDomainName =
firstNonNull(templateOptions.getNetworkDomainName(),
DEFAULT_NETWORK_DOMAIN_NAME);
- String vlanName = firstNonNull(templateOptions.getVlanName(),
DEFAULT_VLAN_NAME);
+ final Set<String> networks = templateOptions.getNetworks();
+
+ String networkDomainName = firstNonNull(!networks.isEmpty() ?
networks.iterator().next() : null,
+
DimensionDataCloudControlTemplateOptions.DEFAULT_NETWORK_DOMAIN_NAME);
Is it possible in DD to attach a server to more than one network? (That's why
the `networks` property is a list). And in that case What
considerations/preconditions/limitations should be taken into account?
If not, instead of silently ignoring all but the first network, it would be
better to validate that there is only one and fail otherwise.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/426#pullrequestreview-83736355
