nacx commented on this pull request.
> @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final
> CreateNodeWithGroupEncod
final DimensionDataCloudControlTemplateOptions templateOptions =
template.getOptions()
.as(DimensionDataCloudControlTemplateOptions.class);
- String networkDomainName =
firstNonNull(templateOptions.getNetworkDomainName(),
DEFAULT_NETWORK_DOMAIN_NAME);
- String vlanName = firstNonNull(templateOptions.getVlanName(),
DEFAULT_VLAN_NAME);
+ final Set<String> networks = templateOptions.getNetworks();
+
+ String networkDomainName = firstNonNull(!networks.isEmpty() ?
networks.iterator().next() : null,
+
DimensionDataCloudControlTemplateOptions.DEFAULT_NETWORK_DOMAIN_NAME);
>I think that recording the lists of VLANs in templateOptions.network might be
>a better approach. My thoughts are that we revert the change to revert the
>networkDomainName removal from DimensionDataCloudControlTemplateOptions
Replace DimensionDataCloudControlTemplateOptions vlanName with
templateOptions.network
Sounds good. Use the DD options to configure the domain name, and read the VLAN
names from the `templateOptions.networks` option.
>OR we could use a Server to retrieve this information and therefore reduce the
>set of Vlans we store in templateOptions.network. Just not sure what you think
>is the best approach?
I'm not sure I get what you mean with this. The `templateOptions.networks`
options are used to tell jclouds where to attach the servers it is about to
create... Could you please clarify what do you mean?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/426#discussion_r157487574
