Jira link: https://issues.apache.org/jira/browse/JCLOUDS-1374
The update focuses on adding SoftLayer LoadBalancer API to the features list of 
SoftLayer provider.

Domain type files:
- Added LoadBalancer.java
- Added LoadBalancerHealthMonitor.java
- Added LoadBalancerListener.java
- Added LoadBalancerListenerDefaultPool.java
- Added LoadBalancerMember.java
- Added LoadBalancerMemberHealth.java
- Added LoadBalancerMemberPoolHealth.java
- Added LoadBalancerProtocolConfiguration.java
- Added LoadBalancerServerInstanceInformation.java
- Added LoadBalancerServicePrice.java
- Added LoadBalancerStatistics.java
- Added LoadBalancerSubnetId.java
- Added Location.java
Features:
- Added LoadBalancerApi.java
- Added LoadBalancerApiLiveTest.java
- Added LoadBalancerApiMockTest.java
- Added resource files for LoadBalancerApiMockTest.java

Notes:
- The users are expected to set variables `subnetId`, `servicePrices`, and 
`testInstancePrivateIp` for LoadBalancerApiLiveTest.
- Since the LoadBalancerApiLiveTest test cases are dependent on other test 
cases (some tests should take precedence), I had to set the threadCount to be 1 
to avoid parallel REST calls in the pom.xml. Added after line 117 for 
`<maven-surefire-plugin>`
```
            <configuration>
              <parallel>methods</parallel>
              <threadCount>1</threadCount>
            </configuration>
```
- The following is the test results of the LoadBalancerApiLiveTest:
```
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
support was removed in 8.0
Running org.jclouds.softlayer.features.LoadBalancerApiLiveTest
Configuring TestNG with: TestNG652Configurator
Starting test 
testCreateLoadBalancer(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
LoadBalancer service is fully created and ready to be tested.
[TestNG] Test 
testCreateLoadBalancer(org.jclouds.softlayer.features.LoadBalancerApiLiveTest) 
succeeded: 315135ms
Test suite progress: tests succeeded: 1, failed: 0, skipped: 0.
Starting test 
testAddLoadBalancerMembers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testAddLoadBalancerMembers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 32067ms
Test suite progress: tests succeeded: 2, failed: 0, skipped: 0.
Starting test 
testGetDatacenter(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetDatacenter(org.jclouds.softlayer.features.LoadBalancerApiLiveTest) 
succeeded: 525ms
Test suite progress: tests succeeded: 3, failed: 0, skipped: 0.
Starting test 
testGetHealthMonitors(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetHealthMonitors(org.jclouds.softlayer.features.LoadBalancerApiLiveTest) 
succeeded: 523ms
Test suite progress: tests succeeded: 4, failed: 0, skipped: 0.
Starting test 
testGetLoadBalancer(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetLoadBalancer(org.jclouds.softlayer.features.LoadBalancerApiLiveTest) 
succeeded: 440ms
Test suite progress: tests succeeded: 5, failed: 0, skipped: 0.
Starting test 
testGetLoadBalancerListeners(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetLoadBalancerListeners(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 509ms
Test suite progress: tests succeeded: 6, failed: 0, skipped: 0.
Starting test 
testGetLoadBalancerObject(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetLoadBalancerObject(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 500ms
Test suite progress: tests succeeded: 7, failed: 0, skipped: 0.
Starting test 
testGetLoadBalancerStatistics(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetLoadBalancerStatistics(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 1061ms
Test suite progress: tests succeeded: 8, failed: 0, skipped: 0.
Starting test 
testListLoadBalancers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testListLoadBalancers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest) 
succeeded: 461ms
Test suite progress: tests succeeded: 9, failed: 0, skipped: 0.
Starting test 
testUpdateLoadBalancer(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testUpdateLoadBalancer(org.jclouds.softlayer.features.LoadBalancerApiLiveTest) 
succeeded: 978ms
Test suite progress: tests succeeded: 10, failed: 0, skipped: 0.
Starting test 
testAddLoadBalancerProtocols(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testAddLoadBalancerProtocols(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 33132ms
Test suite progress: tests succeeded: 11, failed: 0, skipped: 0.
Starting test 
testGetLoadBalancerMember(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetLoadBalancerMember(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 525ms
Test suite progress: tests succeeded: 12, failed: 0, skipped: 0.
Starting test 
testGetLoadBalancerMemberHealth(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetLoadBalancerMemberHealth(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 1079ms
Test suite progress: tests succeeded: 13, failed: 0, skipped: 0.
Starting test 
testGetLoadBalancerMembers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetLoadBalancerMembers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 489ms
Test suite progress: tests succeeded: 14, failed: 0, skipped: 0.
Starting test 
testUpdateHealthMonitor(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testUpdateHealthMonitor(org.jclouds.softlayer.features.LoadBalancerApiLiveTest) 
succeeded: 32393ms
Test suite progress: tests succeeded: 15, failed: 0, skipped: 0.
Starting test 
testUpdateLoadBalancerMembers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testUpdateLoadBalancerMembers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 523ms
Test suite progress: tests succeeded: 16, failed: 0, skipped: 0.
Starting test 
testGetHealthMonitor(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetHealthMonitor(org.jclouds.softlayer.features.LoadBalancerApiLiveTest) 
succeeded: 457ms
Test suite progress: tests succeeded: 17, failed: 0, skipped: 0.
Starting test 
testDeleteLoadBalancerMembers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testDeleteLoadBalancerMembers(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 32520ms
Test suite progress: tests succeeded: 18, failed: 0, skipped: 0.
Starting test 
testUpdateLoadBalancerProtocols(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testUpdateLoadBalancerProtocols(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 32929ms
Test suite progress: tests succeeded: 19, failed: 0, skipped: 0.
Starting test 
testGetLoadBalancerListener(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testGetLoadBalancerListener(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 467ms
Test suite progress: tests succeeded: 20, failed: 0, skipped: 0.
Starting test 
testDeleteLoadBalancerListener(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testDeleteLoadBalancerListener(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
 succeeded: 34895ms
Test suite progress: tests succeeded: 21, failed: 0, skipped: 0.
Starting test 
testDeleteLoadBalancer(org.jclouds.softlayer.features.LoadBalancerApiLiveTest)
[TestNG] Test 
testDeleteLoadBalancer(org.jclouds.softlayer.features.LoadBalancerApiLiveTest) 
succeeded: 62475ms
Test suite progress: tests succeeded: 22, failed: 0, skipped: 0.
Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 586.37 sec - 
in org.jclouds.softlayer.features.LoadBalancerApiLiveTest

Results :

Tests run: 22, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:38 min
[INFO] Finished at: 2018-01-26T16:07:41-06:00
[INFO] Final Memory: 44M/499M
[INFO] ------------------------------------------------------------------------
```
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1176

-- Commit Summary --

  * Added LBaaS_LoadBalancer feature

-- File Changes --

    M providers/softlayer/src/main/java/org/jclouds/softlayer/SoftLayerApi.java 
(7)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancer.java
 (132)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerHealthMonitor.java
 (100)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerListener.java
 (106)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerListenerDefaultPool.java
 (53)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerMember.java
 (116)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerMemberHealth.java
 (42)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerMemberPoolHealth.java
 (42)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerProtocolConfiguration.java
 (52)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerServerInstanceInformation.java
 (43)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerServicePrice.java
 (42)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerStatistics.java
 (50)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/LoadBalancerSubnetId.java
 (42)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/Location.java 
(46)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/features/LoadBalancerApi.java
 (353)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/LoadBalancerApiLiveTest.java
 (529)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/LoadBalancerApiMockTest.java
 (789)
    A providers/softlayer/src/test/resources/loadbalancer_add_listener.json (97)
    A providers/softlayer/src/test/resources/loadbalancer_add_member.json (77)
    A providers/softlayer/src/test/resources/loadbalancer_create.json (337)
    A providers/softlayer/src/test/resources/loadbalancer_delete_listener.json 
(77)
    A providers/softlayer/src/test/resources/loadbalancer_delete_member.json 
(68)
    A providers/softlayer/src/test/resources/loadbalancer_get_170811.json (68)
    A 
providers/softlayer/src/test/resources/loadbalancer_get_datacenter_170811.json 
(5)
    A 
providers/softlayer/src/test/resources/loadbalancer_get_healthmonitors_170811.json
 (12)
    A 
providers/softlayer/src/test/resources/loadbalancer_get_listener_214871.json 
(20)
    A 
providers/softlayer/src/test/resources/loadbalancer_get_listeners_170811.json 
(22)
    A 
providers/softlayer/src/test/resources/loadbalancer_get_member_170811.json (9)
    A 
providers/softlayer/src/test/resources/loadbalancer_get_member_health_170811.json
 (11)
    A 
providers/softlayer/src/test/resources/loadbalancer_get_members_170811.json (11)
    A 
providers/softlayer/src/test/resources/loadbalancer_get_statistics_170811.json 
(8)
    A 
providers/softlayer/src/test/resources/loadbalancer_healthmonitor_get_170811.json
 (12)
    A providers/softlayer/src/test/resources/loadbalancer_list.json (70)
    A 
providers/softlayer/src/test/resources/loadbalancer_update_healthmonitors_170811.json
 (68)
    A providers/softlayer/src/test/resources/loadbalancer_update_listener.json 
(97)
    A 
providers/softlayer/src/test/resources/loadbalancer_update_loadbalancer.json 
(68)
    A providers/softlayer/src/test/resources/loadbalancer_update_member.json 
(77)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1176.patch
https://github.com/jclouds/jclouds/pull/1176.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1176

Reply via email to