andreaturli requested changes on this pull request.
> + @BeforeClass(groups = {"integration", "live"})
+ @Override
+ public void setup() {
+ super.setup();
+
+ loadBalancerApi = api.getLoadBalancerApi();
+
+ datacenter = Iterables.get(api.getDatacenterApi().listDatacenters(), 0);
+ assertNotNull(datacenter, "Datacenter must not be null");
+ }
+
+ @Test
+ public void testCreateLoadBalancer() throws Exception {
+ assertTrue(subnetId != -1, "Please set the subnetId");
+ assertTrue(!testInstancePrivateIp.equals(""), "Please set the
testInstancePrivateIp for Member functions testing");
+ loadBalancer = LoadBalancer.create(0, 0, "", new Date(), "", 0, 0,
why are you creating this mock obj instead of using line 108
> + LoadBalancerMember getLoadBalancerMember(@PathParam("id") int id);
+
+ /**
+ * Add load balancer members
+ * @param LoadBalancerMembersToBeAdded the load balancer member creation
definition of LoadBalancerMember.AddLoadBalancerMember
+ * along with the uuid of the targeted
load balancer
+ * @reutrn new load balancer object
+ * @see <a
href="https://sldn.softlayer.com/reference/services/softlayer_network_lbaas_member/addloadbalancermembers";
/>
+ */
+ @POST
+ @Named("LoadBalanceMember:addLoadBalancerMembers")
+ @Path("SoftLayer_Network_LBaaS_Member/addLoadBalancerMembers")
+ @QueryParams(keys = "objectMask", values = NAME_MASK)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Fallback(NullOnNotFoundOr404.class)
+ LoadBalancer addLoadBalancerMembers(@WrapWith("parameters") List<Object>
LoadBalancerMembersToBeAdded);
is there any better type than `Object`?
> + LoadBalancer addLoadBalancerMembers(@WrapWith("parameters") List<Object>
> LoadBalancerMembersToBeAdded);
+
+ /**
+ * Update member's weight
+ * @param LoadBalancerMembersToBeUpdated the load balancer member edition
definition of LoadBalancerMember.UpdateLoadBalancerMember
+ * along with the uuid of the targeted
load balancer
+ * @reutrn new load balancer object
+ * @see <a
href="https://sldn.softlayer.com/reference/services/SoftLayer_Network_LBaaS_Member/updateLoadBalancerMembers";
/>
+ */
+ @POST
+ @Named("LoadBalanceMember:updateLoadBalancerMembers")
+ @Path("SoftLayer_Network_LBaaS_Member/updateLoadBalancerMembers")
+ @QueryParams(keys = "objectMask", values = NAME_MASK)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Fallback(NullOnNotFoundOr404.class)
+ LoadBalancer updateLoadBalancerMembers(@WrapWith("parameters") List<Object>
LoadBalancerMembersToBeUpdated);
is there any better type than `Object`?
> + LoadBalancer updateLoadBalancerMembers(@WrapWith("parameters")
> List<Object> LoadBalancerMembersToBeUpdated);
+
+ /**
+ * Delete load balancer members
+ * @param LoadBalancerMembersToBeDeleted the array of the load balancer
member uuid along with the uuid of the
+ * targeted load balancer
+ * @reutrn new load balancer object
+ * @see <a
href="https://sldn.softlayer.com/reference/services/SoftLayer_Network_LBaaS_Member/deleteLoadBalancerMembers";
/>
+ */
+ @POST
+ @Named("LoadBalanceMember:deleteLoadBalancerMembers")
+ @Path("SoftLayer_Network_LBaaS_Member/deleteLoadBalancerMembers")
+ @QueryParams(keys = "objectMask", values = NAME_MASK)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Fallback(NullOnNotFoundOr404.class)
+ LoadBalancer deleteLoadBalancerMembers(@WrapWith("parameters") List<Object>
LoadBalancerMembersToBeDeleted);
is there any better type than `Object`?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1176#pullrequestreview-92065202
