nacx commented on this pull request.
Almost there! :)
> super(builder);
}
public static Properties defaultProperties() {
Properties properties =
DimensionDataCloudControlApiMetadata.defaultProperties();
+ properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");
+ properties.setProperty(PROPERTY_REGION + ".na." + ISO3166_CODES, "NA");
Remove
> super(builder);
}
public static Properties defaultProperties() {
Properties properties =
DimensionDataCloudControlApiMetadata.defaultProperties();
+ properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");
+ properties.setProperty(PROPERTY_REGION + ".na." + ISO3166_CODES, "NA");
+ properties.setProperty(PROPERTY_REGION + ".na.zones", "NA9,NA12");
+ properties.setProperty(PROPERTY_ZONE + "NA9" + ISO3166_CODES, "US-VA");
+ properties.setProperty(PROPERTY_ZONE + "NA12" + ISO3166_CODES, "US-CA");
+ properties.setProperty(PROPERTY_REGION + ".eu." + ISO3166_CODES, "EU");
Remove
> super(builder);
}
public static Properties defaultProperties() {
Properties properties =
DimensionDataCloudControlApiMetadata.defaultProperties();
+ properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");
+ properties.setProperty(PROPERTY_REGION + ".na." + ISO3166_CODES, "NA");
+ properties.setProperty(PROPERTY_REGION + ".na.zones", "NA9,NA12");
+ properties.setProperty(PROPERTY_ZONE + "NA9" + ISO3166_CODES, "US-VA");
+ properties.setProperty(PROPERTY_ZONE + "NA12" + ISO3166_CODES, "US-CA");
+ properties.setProperty(PROPERTY_REGION + ".eu." + ISO3166_CODES, "EU");
+ properties.setProperty(PROPERTY_REGION + ".eu.zones", "EU6,EU7,EU8");
+ properties.setProperty(PROPERTY_ZONE + "EU6" + ISO3166_CODES, "DE-HE");
+ properties.setProperty(PROPERTY_ZONE + "EU7" + ISO3166_CODES, "NL-NH");
+ properties.setProperty(PROPERTY_ZONE + "EU8" + ISO3166_CODES, "BE-BRU");
+ properties.setProperty(PROPERTY_REGION + ".au." + ISO3166_CODES, "AU");
Remove
> + properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");
+ properties.setProperty(PROPERTY_REGION + ".na." + ISO3166_CODES, "NA");
+ properties.setProperty(PROPERTY_REGION + ".na.zones", "NA9,NA12");
+ properties.setProperty(PROPERTY_ZONE + "NA9" + ISO3166_CODES, "US-VA");
+ properties.setProperty(PROPERTY_ZONE + "NA12" + ISO3166_CODES, "US-CA");
+ properties.setProperty(PROPERTY_REGION + ".eu." + ISO3166_CODES, "EU");
+ properties.setProperty(PROPERTY_REGION + ".eu.zones", "EU6,EU7,EU8");
+ properties.setProperty(PROPERTY_ZONE + "EU6" + ISO3166_CODES, "DE-HE");
+ properties.setProperty(PROPERTY_ZONE + "EU7" + ISO3166_CODES, "NL-NH");
+ properties.setProperty(PROPERTY_ZONE + "EU8" + ISO3166_CODES, "BE-BRU");
+ properties.setProperty(PROPERTY_REGION + ".au." + ISO3166_CODES, "AU");
+ properties.setProperty(PROPERTY_REGION + ".au.zones", "AU9,AU10,AU11");
+ properties.setProperty(PROPERTY_ZONE + "AU9" + ISO3166_CODES, "AU-NSW");
+ properties.setProperty(PROPERTY_ZONE + "AU10" + ISO3166_CODES, "AU-VIC");
+ properties.setProperty(PROPERTY_ZONE + "AU11" + ISO3166_CODES, "NZ-WKO");
+ properties.setProperty(PROPERTY_REGION + ".mea." + ISO3166_CODES, "AF");
Remove
> + properties.setProperty(PROPERTY_ZONE + "NA9" + ISO3166_CODES, "US-VA");
+ properties.setProperty(PROPERTY_ZONE + "NA12" + ISO3166_CODES, "US-CA");
+ properties.setProperty(PROPERTY_REGION + ".eu." + ISO3166_CODES, "EU");
+ properties.setProperty(PROPERTY_REGION + ".eu.zones", "EU6,EU7,EU8");
+ properties.setProperty(PROPERTY_ZONE + "EU6" + ISO3166_CODES, "DE-HE");
+ properties.setProperty(PROPERTY_ZONE + "EU7" + ISO3166_CODES, "NL-NH");
+ properties.setProperty(PROPERTY_ZONE + "EU8" + ISO3166_CODES, "BE-BRU");
+ properties.setProperty(PROPERTY_REGION + ".au." + ISO3166_CODES, "AU");
+ properties.setProperty(PROPERTY_REGION + ".au.zones", "AU9,AU10,AU11");
+ properties.setProperty(PROPERTY_ZONE + "AU9" + ISO3166_CODES, "AU-NSW");
+ properties.setProperty(PROPERTY_ZONE + "AU10" + ISO3166_CODES, "AU-VIC");
+ properties.setProperty(PROPERTY_ZONE + "AU11" + ISO3166_CODES, "NZ-WKO");
+ properties.setProperty(PROPERTY_REGION + ".mea." + ISO3166_CODES, "AF");
+ properties.setProperty(PROPERTY_REGION + ".mea.zones", "AF3");
+ properties.setProperty(PROPERTY_ZONE + "AF3" + ISO3166_CODES, "ZA-GT");
+ properties.setProperty(PROPERTY_REGION + ".ap." + ISO3166_CODES, "AP");
Remove
> + properties.setProperty(PROPERTY_ZONE + "EU6" + ISO3166_CODES, "DE-HE");
+ properties.setProperty(PROPERTY_ZONE + "EU7" + ISO3166_CODES, "NL-NH");
+ properties.setProperty(PROPERTY_ZONE + "EU8" + ISO3166_CODES, "BE-BRU");
+ properties.setProperty(PROPERTY_REGION + ".au." + ISO3166_CODES, "AU");
+ properties.setProperty(PROPERTY_REGION + ".au.zones", "AU9,AU10,AU11");
+ properties.setProperty(PROPERTY_ZONE + "AU9" + ISO3166_CODES, "AU-NSW");
+ properties.setProperty(PROPERTY_ZONE + "AU10" + ISO3166_CODES, "AU-VIC");
+ properties.setProperty(PROPERTY_ZONE + "AU11" + ISO3166_CODES, "NZ-WKO");
+ properties.setProperty(PROPERTY_REGION + ".mea." + ISO3166_CODES, "AF");
+ properties.setProperty(PROPERTY_REGION + ".mea.zones", "AF3");
+ properties.setProperty(PROPERTY_ZONE + "AF3" + ISO3166_CODES, "ZA-GT");
+ properties.setProperty(PROPERTY_REGION + ".ap." + ISO3166_CODES, "AP");
+ properties.setProperty(PROPERTY_REGION + ".ap.zones", "AP4,AP5");
+ properties.setProperty(PROPERTY_ZONE + "AP4" + ISO3166_CODES, "JP-13");
+ properties.setProperty(PROPERTY_ZONE + "AP5" + ISO3166_CODES, "HK");
+ properties.setProperty(PROPERTY_REGION + ".canada." + ISO3166_CODES,
"CA");
Remove
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/433#pullrequestreview-113614855
