nacx commented on a change in pull request #78:
URL: https://github.com/apache/jclouds/pull/78#discussion_r445662552



##########
File path: project/pom.xml
##########
@@ -86,6 +86,16 @@
   </scm>
 
   <repositories>
+    <repository>
+      <id>gitlab-maven</id>
+      <url>https://gitlab.com/api/v4/projects/19575612/packages/maven</url>

Review comment:
       So, first, we need to make sure packages there are ASLv2 compliant, and 
then yes, we need to make sure we pull dependencies from a source that is 
guaranteed _to be there's forever. Apache releases must be always buildable 
from source, and I'm not sure if depending on this would meet these guarantees.
   Apart from this, I've already commented on my main concerns in the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to