yaooqinn commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r830008025



##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
   cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
 fi
 
+if [[ "$HIVE_PROVIDED" != "true" ]]; then

Review comment:
       >I forgot, this PR needs to be merged in 
https://github.com/apache/incubator-kyuubi/issues/2024 to work properly.
   
   yes, you are right. 
   
   > not related to this PR only, if we build/package without hive distribution 
with maven, the below will fail
   
   This is another issue we may face if we `build/dist ` with download releases 
skipped.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to