cxzl25 commented on a change in pull request #2169:
URL: https://github.com/apache/incubator-kyuubi/pull/2169#discussion_r830004802
##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
fi
+if [[ "$HIVE_PROVIDED" != "true" ]]; then
Review comment:
I forgot, this PR needs to be merged in
https://github.com/apache/incubator-kyuubi/issues/2024 to work properly.
##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
fi
+if [[ "$HIVE_PROVIDED" != "true" ]]; then
Review comment:
I forgot, this PR needs to be merged in
https://github.com/apache/incubator-kyuubi/issues/2024 to work properly.
That's why I added WIP to the title.
##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
fi
+if [[ "$HIVE_PROVIDED" != "true" ]]; then
Review comment:
I probably know what you mean.
If you mean to use maven -D parameter to skip the release download of hive
or other engines, an error will be reported here.
```
build/dist --tgz --spark-provided --flink-provided -Pspark-3.2
-Dhive.archive.download.skip=true
```
##########
File path: build/dist
##########
@@ -279,6 +295,12 @@ if [[ "$SPARK_PROVIDED" != "true" ]]; then
cp -r "$SPARK_BUILTIN" "$DISTDIR/externals/"
fi
+if [[ "$HIVE_PROVIDED" != "true" ]]; then
Review comment:
Maybe do this after `#Parse arguments`.
```bash
mvn help:evaluate -Dexpression=hive.archive.download.skip
-Dhive.archive.download.skip=false | grep -v INFO | grep -v WARNING
```
Do I need to make changes in this PR? or new open issue to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
