pan3793 commented on code in PR #2622:
URL: https://github.com/apache/incubator-kyuubi/pull/2622#discussion_r869144795
##########
extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSBatchScan.scala:
##########
@@ -65,6 +65,16 @@ class TPCDSBatchScan(
val chuck = partition.asInstanceOf[TPCDSTableChuck]
new TPCDSPartitionReader(chuck.table, chuck.scale, chuck.parallelism,
chuck.index, schema)
}
+
+ override def estimateStatistics(): Statistics = {
+ new Statistics {
+ override def sizeInBytes(): OptionalLong = {
+ OptionalLong.of(rowCount * schema.defaultSize)
Review Comment:
The TPC-DS document actually provides a table with estimate row size of each
table. I'm now sure which one is better here.
https://tpc.org/TPC_Documents_Current_Versions/pdf/TPC-DS_v3.2.0.pdf
<img width="796" alt="image"
src="https://user-images.githubusercontent.com/26535726/167622496-2dbc1017-668c-4775-8eba-7bcd03640df2.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/26535726/167622496-2dbc1017-668c-4775-8eba-7bcd03640df2.png"](https://user-images.githubusercontent.com/26535726/167622496-2dbc1017-668c-4775-8eba-7bcd03640df2.png"){kind=link}