[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #2622: [KYUUBI #2539] [Subtask] Kyuubi Spark TPC-DS Connector - SupportsReportStatistics

Tue, 10 May 2022 06:34:37 -0700 


cxzl25 commented on code in PR #2622:
URL: https://github.com/apache/incubator-kyuubi/pull/2622#discussion_r869243557


##########
extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSBatchScan.scala:
##########
@@ -65,6 +65,16 @@ class TPCDSBatchScan(
     val chuck = partition.asInstanceOf[TPCDSTableChuck]
     new TPCDSPartitionReader(chuck.table, chuck.scale, chuck.parallelism, 
chuck.index, schema)
   }
+
+  override def estimateStatistics(): Statistics = {
+    new Statistics {
+      override def sizeInBytes(): OptionalLong = {
+        OptionalLong.of(rowCount * schema.defaultSize)

Review Comment:
   I am now trying to use the avg size of tpcds.
   
   
![image](https://user-images.githubusercontent.com/3898450/167640805-6137a82e-5f9e-448a-add2-998486f7745f.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to