turboFei commented on code in PR #2647:
URL: https://github.com/apache/incubator-kyuubi/pull/2647#discussion_r872275161
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSession.scala:
##########
@@ -29,6 +31,17 @@ abstract class KyuubiSession(
sessionManager: KyuubiSessionManager)
extends AbstractSession(protocol, user, password, ipAddress, conf,
sessionManager) {
- def getSessionEvent: Option[KyuubiSessionEvent]
+ private[kyuubi] lazy val optimizedConf: Map[String, String] = {
+ val confOverlay = sessionManager.sessionConfAdvisor.getConfOverlay(
Review Comment:
In my opinion, maybe we need a new method for batch conf overlay.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkBatchProcessBuilder.scala:
##########
@@ -53,8 +53,11 @@ class SparkBatchProcessBuilder(
buffer += s"$k=$v"
}
- buffer += PROXY_USER
- buffer += proxyUser
+ // iff the keytab is specified, PROXY_USER is not supported
Review Comment:
typo: if
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
