turboFei commented on code in PR #2647:
URL: https://github.com/apache/incubator-kyuubi/pull/2647#discussion_r872298417
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSession.scala:
##########
@@ -29,6 +31,17 @@ abstract class KyuubiSession(
sessionManager: KyuubiSessionManager)
extends AbstractSession(protocol, user, password, ipAddress, conf,
sessionManager) {
- def getSessionEvent: Option[KyuubiSessionEvent]
+ private[kyuubi] lazy val optimizedConf: Map[String, String] = {
+ val confOverlay = sessionManager.sessionConfAdvisor.getConfOverlay(
Review Comment:
by defaults, the batch conf overlay could be same with the original one, but
it is better to have two separate methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
