yaooqinn commented on code in PR #2678:
URL: https://github.com/apache/incubator-kyuubi/pull/2678#discussion_r874615145
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/FetchIterator.scala:
##########
@@ -109,3 +109,26 @@ class IterableFetchIterator[A](iterable: Iterable[A])
extends FetchIterator[A] {
}
}
}
+
+object FetchIterator {
+
+ def from[A](iter: Iterator[A]): FetchIterator[A] = new FetchIterator[A] {
Review Comment:
is this so common to have this name? it seems very easy to misuse this
implementation in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
