iodone commented on PR #2678:
URL:
https://github.com/apache/incubator-kyuubi/pull/2678#issuecomment-1129527994
> > > I think we can give an option to cache the result on engine side, it
will not affect Kyuubi server even if engine crash by OOM. Another idea is
re-run query if the client request the fetch FIRST after consuming, it's
usually for export cases.
> >
> >
> > Can we consider implementing FETCH_FIRST in KyuybiJDBC Client, so that
keep the immediate result return feature of trino?
>
> Or we just Keep the previous `execute(): Iterable[List[Any]]` as
`executeCollect(): Iterable[List[Any]]` , and run:
>
> ```
> iter =
> if (incrementalCollect) {
> info("Execute in incremental collect mode")
> FetchIterator.fromIterator(trinoStatement.execute())
> } else {
> info("Execute in full collect mode")
> new ArrayFetchIterator(trinoStatement.executeCollect())
> }
> ```
Good advice, I'll try it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
